feat(switch): enhances Switch component to allow inline variant in new validation redesign #7023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damienrobson-sage
force-pushed
the
FE-6780-inline-switch
branch
from
26bf78c
to
bd27ac2
Compare
damienrobson-sage
added
Pending Review
Pending QA
Pending UX QA
Squad Front End
switch
and removed
DO NOT MERGE
labels
edleeks87
reviewed
Oct 23, 2024
src/components/switch/__internal__/switch-slider-panel.style.ts
Outdated
Show resolved
Hide resolved
damienrobson-sage
force-pushed
the
FE-6780-inline-switch
branch
from
7869882
to
bcae863
Compare
damienrobson-sage
force-pushed
the
FE-6780-inline-switch
branch
from
173ea11
to
a720b7e
Compare
edleeks87
previously approved these changes
Oct 24, 2024
damienrobson-sage
force-pushed
the
FE-6780-inline-switch
branch
from
a720b7e
to
08e1702
Compare
mihai-albu-sage
previously approved these changes
Oct 24, 2024
edleeks87
previously approved these changes
Oct 25, 2024
damienrobson-sage
dismissed stale reviews from mihai-albu-sage and edleeks87
via
e2aa03b
damienrobson-sage
force-pushed
the
FE-6780-inline-switch
branch
2 times, most recently
from
e2aa03b
to
69c6630
Compare
edleeks87
reviewed
Oct 29, 2024
src/__internal__/validation-message/validation-message.style.ts
Outdated
Show resolved
Hide resolved
|
Looks good to me, wanted to add there is a minor alignment review we need to look at the inline layout but its rendering slightly different in different browsers so that will not impact this ticket. |
mihai-albu-sage
previously approved these changes
Oct 29, 2024
edleeks87
previously approved these changes
Oct 30, 2024
damienrobson-sage
dismissed stale reviews from edleeks87 and mihai-albu-sage
via
785bbb4
damienrobson-sage
force-pushed
the
FE-6780-inline-switch
branch
2 times, most recently
from
785bbb4
to
ba04c3b
Compare
edleeks87
reviewed
Oct 31, 2024
damienrobson-sage
force-pushed
the
FE-6780-inline-switch
branch
from
ba04c3b
to
d0e81e1
Compare
…w validation redesign
damienrobson-sage
force-pushed
the
FE-6780-inline-switch
branch
from
ddff174
to
baf4ac5
Compare
edleeks87
approved these changes
Nov 5, 2024
mihai-albu-sage
approved these changes
Nov 6, 2024
dariusbercea-sage
approved these changes
Nov 7, 2024
|
🎉 This PR is included in version 144.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
Adds the following enhancements to the
Switchcomponent:This will allow the inline option to work alongside the
validationRedesignOptInflag. If the inline layout does not fit the space provided, it will default to the vertical style layout.Current behaviour
The
Switchcomponent does not currently support inline layouts if thevalidationRedesignOptInflag is set to trueChecklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions